Fix localization filenames and preserve signature of swt.jar #2007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HannesWell
force-pushed
the
fix-swt.jar-signatures
branch
from
45f9c03 to
f26a59d
Compare
In the SWT fragment jars published in the Eclipse p2-repository the localization files had the wrong names, which are used at dev-time to avoid localization when launching SWT from a development environment. Furthermore the 'swt.jar' is now not modified anymore before adding it to the assembly for the download-page, which ensures intact signatures. Fixes eclipse-platform/eclipse.platform.releng.aggregator#2189
HannesWell
force-pushed
the
fix-swt.jar-signatures
branch
from
f26a59d to
2c5618b
Compare
Member
Author
|
Results look good, although the jars are not signed in the verification build but the jar built for the p2-repo and the one included in the SWT.zip published at the download page are identical. With tonight's I-build the published zips should have the expected content. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the SWT fragment jars published in the Eclipse p2-repository the localization files had the wrong names, which are used at dev-time to avoid localization when launching SWT from a development environment.
Furthermore the 'swt.jar' is now not modified anymore before adding it to the assembly for the download-page, which ensures intact signatures.
Fixes eclipse-platform/eclipse.platform.releng.aggregator#2189